Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overlapped local replacement #156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: overlapped local replacement #156

wants to merge 2 commits into from

Commits on Oct 20, 2024

  1. fix: overlapped local replacement 

    One golang standalone module can exists inside another module, when we
replace such module to local directory, we'll try to create symbolic link
inside the source directory and `ln` complains permission denied.

For example, both `cosmossdk.io/x/accounts` and `cosmossdk.io/x/accounts/defaults/lockup`
are standalone modules, if we do `replace cosmossdk.io/x/accounts => ./x/accounts`,
we'll try to create two symbolic links like this:

```
$ ln -s ./x/accounts vendor/cosmossdk.io/x/accounts
$ ln -s ./x/accounts/defaults/lockup vendor/cosmossdk.io/x/accounts/defaults/lockup
```

And the second one is inside source directory and fails.

The temporary solution here is to simply ignore the symbolic link error,
not ideal, but fix the issue at hand, and should have not side effect on existing projects.
    @yihuang @marcusramberg
    yihuang authored and marcusramberg committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    04185d7 View commit details
    Browse the repository at this point in the history

  2. Update builder/default.nix

    @yihuang @marcusramberg
    yihuang authored and marcusramberg committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    f84a968 View commit details
    Browse the repository at this point in the history