Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nix, package configurable. #137

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

mikepurvis
Copy link

@mikepurvis mikepurvis commented Aug 9, 2023

Addresses #136, making it possible to deploy the harmonia-dev module on systems with an older nixpkgs without overlay shenanigans— tell the module what Harmonia package to use, and tell that Harmonia package which Nix to build against:

  services.harmonia-dev = {
    enable = true;
    package = harmonia.packages.${system}.harmonia.override {
      inherit (nix_2_17.packages.${system}) nix;
    };
  };

@Mic92
Copy link
Member

Mic92 commented Aug 10, 2023

@Mic92
Copy link
Member

Mic92 commented Aug 10, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Aug 10, 2023

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge train check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mikepurvis
Copy link
Author

mikepurvis commented Aug 10, 2023

I saw, yes! But I'm interested in getting the latest fixes that are in this repo, and I also am running some patches on top of hydra-dev as well, so it feels easier to run them from their flakes than try to deal with overriding the upstreamed versions.

Ironically, CI for this is failing in the exact same way that this change is meant to make easier to prevent/overcome— it's trying to link against a version of nix that's too old.

default.nix Outdated Show resolved Hide resolved
default.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented Aug 12, 2023

@mergify queue

@mergify
Copy link

mergify bot commented Aug 12, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f292063

@mergify mergify bot merged commit f292063 into nix-community:master Aug 12, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants