-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP blueprint #1563
base: master
Are you sure you want to change the base?
WIP blueprint #1563
Conversation
c08844e
to
9312f48
Compare
# version = inputs.hydra.shortRev; | ||
# src = inputs.hydra; | ||
# buildInputs = o.buildInputs ++ [ final.perlPackages.DBIxClassHelpers ]; | ||
# }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be moved to packages/hydra/default.nix
, and then pulled in the module with services.hydra.package = perSystem.self.hydra
;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With lite-config this overlay is applied to pkgs
so we don't need to do any additional wiring, e.g. .#nixosConfigurations.build03
and .#checks.x86_64-linux.nixosTests-hydra
both just work. It is also exposed directly in .#packages.${system}.hydra
.
flake.nix
Outdated
# treefmt = { | ||
# flakeCheck = system == "x86_64-linux"; | ||
# imports = [ ./dev/treefmt.nix ]; | ||
# }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can create a package/formatter/default.nix
for this.
See https://github.com/zimbatm/home/blob/main/packages/formatter/default.nix
Autoloading host config, modules, devshells, packages is good but I think I'd rather just handle the checks manually. Some things doesn't need to be exposed except as a check and others I want exposed on all platforms but CI should only build one platform. Minor nit, might be nice to hide these if they aren't used but maybe that is something better handled by flake schemas.
|
Thanks for the feedback. For the checks, would it help if I added a checks/ folder that works like the packages/ folder? To restrict the checks to specific platforms, you can annotate them with the |
No, I realise that follows the existing pattern but checks folder and meta.platforms makes it more complicated than it needs to be. This is fine, just need a way to do it.
|
So the part that's really custom is:
What if you could extend the checks more easily, and let the rest be managed by blueprint? |
Isn't this going to end up being basically same as what I was asking for as some of the default ones will need to be disabled? |
No description provided.