Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only fetch pubkey in case we want to build on remote #240

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 28, 2023

This is a bit faster and also helps to mitigated cases where additionally options that are not respected by ssh-keyscan (i.e. JumpHost) are used

This is a bit faster and also helps to mitigated cases where additionally options
that are not respected by ssh-keyscan (i.e. JumpHost) are used
Copy link
Member

@phaer phaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, was wondering about usage but pubkey is only ever used if remote builds are active

@phaer
Copy link
Member

phaer commented Oct 28, 2023

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2023

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 0a929da

@mergify mergify bot merged commit 0a929da into main Oct 28, 2023
3 checks passed
@mergify mergify bot deleted the optional-pubkey branch October 28, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants