Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option --ssh-store-settings #358

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aabccd021
Copy link

This flag allows users to run nixos-anywhere with extra settings for SSH store, by appending it to ssh store url.

If a user has fast connection between client and target, but slow internet connection on target, the user can use --no-substitute-on-destination to copy closures from client instead of downloading it from internet.

The copy speed (nix-copy to ssh store) can be greatly improved by enabling compression via --ssh-store-settings "compress=true".

Existing url parameters (especially the special characters) need to be encoded to avoid unexpected results. Otherwise we will get something like root evaluates to /mnt?compression=true.

@aabccd021
Copy link
Author

The code intentionally have ? and & at the end of the URL even without store settings passed, which is still a valid URL.

This is done to avoid complexity and make the PR diff as small as possible.

Please let me know if we want to not include these characters when ssh store settings are not used.

@aabccd021 aabccd021 force-pushed the main branch 2 times, most recently from aeb6325 to 3e1944d Compare August 13, 2024 23:30
@phaer
Copy link
Member

phaer commented Oct 19, 2024

@aabccd021 Sorry for the delayed response. Idea sounds good to me - could you rebase?

@aabccd021 aabccd021 reopened this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants