-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose --generate-hardware-config nixos-facter
thru TF
#408
Conversation
…in TF as `var.nixos_generate_config_path`
44212ac
to
b8d1b40
Compare
add `var.nixos_facter_path` to TF modules `install` / `all-in-one`. c.f. nix-community#407, which handled `--generate-hardware-config nixos-generate-config`.
b8d1b40
to
9462024
Compare
…path are mutally exclusive
342b543
to
352131f
Compare
We don't have a integration test for terraform. @KiaraGrouwstra could you test this one more time to make sure nothing is broken. Otherwise I would need to run a test later. |
tho in retrospect separate from TF, i pushed an update to the nixos-anywhere bash script to ensure any directories of hardware configuration files would be created, if needed. that made it a bit more robust, and had it go thru for me. as in #407, in my use i am still checking if |
The git add we already do: nixos-anywhere/src/nixos-anywhere.sh Line 458 in 3fb834d
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 51d347d |
add
var.nixos_facter_path
to TF modulesinstall
/all-in-one
.c.f. #407, which handled
--generate-hardware-config nixos-generate-config
.P.S.: this PR builds upon that one, figuring it would be more elegant to use the
elif
than have two separateif
statements.