Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to hercules ci #87

Closed
wants to merge 2 commits into from
Closed

switch to hercules ci #87

wants to merge 2 commits into from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Apr 2, 2023

No description provided.

@zowoq
Copy link
Contributor Author

zowoq commented Apr 2, 2023

@Mic92 Can I enable hercules for this repo, will it interfere with the current build/release process?

bors.toml Outdated
"check kexec-installer-unstable [x86_64-linux]",
"package netboot-nixos-unstable [x86_64-linux]"
]
status = [ ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list will need to include the Hercules CI checks

@@ -0,0 +1,3 @@
builds:
exclude:
- "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well remove the Garnix app from the repo instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to save some cycles, I'll drop this and the garnix app can be disabled when we're ready to merge.

@zowoq zowoq force-pushed the hercules branch 4 times, most recently from dc64274 to dab1dac Compare April 6, 2023 06:54
@Mic92
Copy link
Member

Mic92 commented Apr 6, 2023

@Mic92 Can I enable hercules for this repo, will it interfere with the current build/release process?

Sure.

@Mic92
Copy link
Member

Mic92 commented Apr 6, 2023

@zowoq Just so you are aware, there are people/customers relying on these assets to be available: https://github.com/nix-community/nixos-images/releases/tag/nixos-unstable so please make sure they don't get accidentally deleted or if they do they are quickly restored.

@zowoq zowoq force-pushed the hercules branch 3 times, most recently from 9457781 to 4ecec9f Compare April 6, 2023 08:42
@zowoq
Copy link
Contributor Author

zowoq commented Apr 6, 2023

It's a bit awkward running the script in an effect so I'll leave that for now.

I'll swap out garnix for hercules and keep the release process in the action.

@zowoq
Copy link
Contributor Author

zowoq commented Apr 29, 2023

I'll pick this up again in the next couple of weeks.

I'll probably rewrite the script as an effect and let hercules create/merge the flake updates to avoid issues with bors, effects have some new features for publishing releases that may be useful as well.

I'll create a fork in this org to work on so I can test publishing releases without disrupting this repo.

@Kranzes
Copy link
Member

Kranzes commented May 3, 2023

I have some WIP fork for this, it requires a couple of features to be added to HCI's github releases effect.
https://github.com/Kranzes/nixos-images/
hercules-ci/hercules-ci-effects#132

@zowoq
Copy link
Contributor Author

zowoq commented May 4, 2023

I was looking at using the same tag (e.g. artifacts) for both stable and unstable and versioning the files, thought that might be simpler?

gh release delete artifacts
gh release create artifacts --title "build $date" "$files"
bzImage-aarch64-22.11-linux
bzImage-aarch64-unstable-linux
bzImage-x86_64-22.11-linux
bzImage-x86_64-unstable-linux
initrd-aarch64-22.11-linux
initrd-aarch64-unstable-linux
initrd-x86_64-22.11-linux
initrd-x86_64-unstable-linux
netboot-aarch64-22.11-linux.ipxe
netboot-aarch64-unstable-linux.ipxe
netboot-x86_64-22.11-linux.ipxe
netboot-x86_64-unstable-linux.ipxe
nixos-kexec-installer-aarch64-22.11-linux.tar.gz 
nixos-kexec-installer-aarch64-unstable-linux.tar.gz 
nixos-kexec-installer-x86_64-22.11-linux.tar.gz 
nixos-kexec-installer-x86_64-unstable-linux.tar.gz 

@Mic92
Copy link
Member

Mic92 commented May 4, 2023

I was looking at using the same tag (e.g. artifacts) for both stable and unstable and versioning the files, thought that might be simpler?

gh release delete artifacts
gh release create artifacts --title "build $date" "$files"
bzImage-aarch64-22.11-linux
bzImage-aarch64-unstable-linux
bzImage-x86_64-22.11-linux
bzImage-x86_64-unstable-linux
initrd-aarch64-22.11-linux
initrd-aarch64-unstable-linux
initrd-x86_64-22.11-linux
initrd-x86_64-unstable-linux
netboot-aarch64-22.11-linux.ipxe
netboot-aarch64-unstable-linux.ipxe
netboot-x86_64-22.11-linux.ipxe
netboot-x86_64-unstable-linux.ipxe
nixos-kexec-installer-aarch64-22.11-linux.tar.gz 
nixos-kexec-installer-aarch64-unstable-linux.tar.gz 
nixos-kexec-installer-x86_64-22.11-linux.tar.gz 
nixos-kexec-installer-x86_64-unstable-linux.tar.gz 

I think I prefer using tags per release. Reason is that I don't want to delete old releases but stop updating them at some point. Also over time we might add/remove images.

@Kranzes
Copy link
Member

Kranzes commented May 4, 2023

I agree that seperate releases is the way to go, someone just needs to implement the missing features to the HCI effect.

@zowoq
Copy link
Contributor Author

zowoq commented May 4, 2023

@Kranzes Do you want to take this over?

@Kranzes
Copy link
Member

Kranzes commented May 4, 2023

@Kranzes Do you want to take this over?

Sure, I mean I've already done most of the work needed (see my fork). Only thing missing some some changes to HCI.

@zowoq zowoq closed this May 4, 2023
@zowoq zowoq deleted the hercules branch May 4, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants