plugins/lazy.nvim: new plugin manager

[ck3mp3r]

This PR addresses #797

[alisonjenkins]

Looks good, I will have a play with this on the weekend.

I have thoughts on the 'build' part of Lazy though. Ideally the build would be unnecessary in Nixvim as it should have already been built and put into Nixpkgs as part of the packaging of dependencies. Is this not the case for plugins you have tested?

If it isn't I wonder if we can create a derivation in some sane manner to ensure that the dependencies are built in a reproducible way that can be fed to Lazy instead of doing the build inside of Lazy.

[traxys]

Really nice!

I think we could improve a bit in the future the opts (or config, not sure) field by providing a function of the form helpers.initLuaFromModule ({...}: {#nixvim module}, but this is larger than the scope of simply lazy.nvim.

[jla2000]

Would it somehow be possible to configure a plugin that already comes with nixvim (like eg telescope) using the options provided in nixvim, but then use lazy to load this plugin?

[GaetanLepage]

Would it somehow be possible to configure a plugin that already comes with nixvim (like eg telescope) using the options provided in nixvim, but then use lazy to load this plugin?

This is the goal in the long term but we are not there yet.
Discussion is happening in #421.

[ck3mp3r]

@alisonjenkins

I have thoughts on the 'build' part of Lazy though. Ideally the build would be unnecessary in Nixvim as it should have already been built and put into Nixpkgs as part of the packaging of dependencies. Is this not the case for plugins you have tested?

Totally, I should have come to that conclusion myself 😆

[ck3mp3r]

@traxys is there a slightly more elegant way than doing this?

helpers.mkNullOrOption (either (maybeRaw str) (maybeRaw (listOf str)))

It does the trick but it has a certain "smell" :)

[traxys]

@traxys is there a slightly more elegant way than doing this?

helpers.mkNullOrOption (either (maybeRaw str) (maybeRaw (listOf str)))

It does the trick but it has a certain "smell" :)

helpers.mkNullOrOption (maybeRaw (either str (listOf str))) ?

[ck3mp3r]

@traxys Ohh, just seen your comment in the thread above, let me try the parenthesis the other way!

Update:

Yup, that was it, forgot the parenthesis the first time... funny I remembered to apply them in the smelly version...

[ck3mp3r]

Just slightly meta: the revisions to this PR were done in a nixvim instance that uses this plugin manager.
I think, unless there are any other remarks/suggestions, I'll mark this PR as ready to merge...

[ck3mp3r]

@traxys can we land this soonish?

[jla2000]

@ck3mp3r Was the "import" lazy.nvim option forgotten or intentionally left out?
I tried doing something like this, but there seems to be no nix option for that:

plugins.lazy = {
  enable = true;
  plugins = with pkgs.vimPlugins; [
    {
      pkg = LazyVim;
      import = "lazyvim.plugins";
    }
  ];
};

error: The option `plugins.lazy.plugins."[definition 1-entry 1]".import' does not exist.

[traxys]

There are quite a lot of really long lines, mainly due to descriptions. Could you use '' quotes, and split them on multiple lines?

[ck3mp3r]

I'll see when I have time to address these issues. For the time being I need to get back to my day job.
Alternatively we can merge this, it does the trick, and we can then refactor and improve, as I don't see any of the interfaces change the way this plugin is going to be used.

On a different note: I am not sure the abstraction being added by nixvim isn't doing more harm than good. The more I use it the more I want to keep things simple in the nix realm and allow configuration that isn't related to packaging and distribution to be just handled by the neovim ecosystem...

[ck3mp3r]

@ck3mp3r Was the "import" lazy.nvim option forgotten or intentionally left out? I tried doing something like this, but there seems to be no nix option for that:

plugins.lazy = {
  enable = true;
  plugins = with pkgs.vimPlugins; [
    {
      pkg = LazyVim;
      import = "lazyvim.plugins";
    }
  ];
};

error: The option `plugins.lazy.plugins."[definition 1-entry 1]".import' does not exist.

@jla2000 this is not currently in scope. It would have to be translated to nix as it is lazy.nvim specific functionality for bundling plugin dependencies.

[jla2000]

Just slightly meta: the revisions to this PR were done in a nixvim instance that uses this plugin manager.

@ck3mp3r Just curious, how did you install treesitter grammars with the lazy.nvim setup? Does it even work at the moment?

[ck3mp3r]

Just slightly meta: the revisions to this PR were done in a nixvim instance that uses this plugin manager.

@ck3mp3r Just curious, how did you install treesitter grammars with the lazy.nvim setup? Does it even work at the moment?

@jla2000 have a look here, this is my current testing branch. It works fine actually :)
https://github.com/ck3mp3r/xvim/blob/lazy/config/treesitter.nix

[jla2000]

Ah I see, you have to add it to the runtime path again since lazy clears it :) Thanks!

[traxys]

I'll see when I have time to address these issues. For the time being I need to get back to my day job. Alternatively we can merge this, it does the trick, and we can then refactor and improve, as I don't see any of the interfaces change the way this plugin is going to be used.

On a different note: I am not sure the abstraction being added by nixvim isn't doing more harm than good. The more I use it the more I want to keep things simple in the nix realm and allow configuration that isn't related to packaging and distribution to be just handled by the neovim ecosystem...

There are two main ways to write nixvim modules, the way this PR does it (the "old" way) where we type every option strictly, but there is another way we are starting to look into, inspired by the NixOS RFC 42, that uses freeform options and a lot less magic