Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document ptr type casting in CONVENTIONS.md #2197

Merged
merged 3 commits into from
Nov 23, 2023
Merged

docs: document ptr type casting in CONVENTIONS.md #2197

merged 3 commits into from
Nov 23, 2023

Conversation

SteveLauC
Copy link
Member

What does this PR do

Document that we prefer cast(), cast_mut() and cast_const() to cast pointer types over the as keyword in CONVENTIONS.md

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@SteveLauC SteveLauC requested a review from asomers November 23, 2023 01:06
asomers
asomers reviewed Nov 23, 2023
View reviewed changes
CONVENTIONS.md Outdated Show resolved Hide resolved
asomers
asomers requested changes Nov 23, 2023
View reviewed changes
CONVENTIONS.md Outdated Show resolved Hide resolved
@SteveLauC @asomers
rephrase it
26bd9bd 
Co-authored-by: Alan Somers <[email protected]>
@asomers asomers added this pull request to the merge queue Nov 23, 2023
Merged via the queue into nix-rust:master with commit c1147c6 Nov 23, 2023
34 checks passed
@SteveLauC SteveLauC deleted the ptr_cast branch November 23, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SteveLauC @asomers