-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sockopt_impl! public #2556
Conversation
e13c295
to
9f6ef59
Compare
This allows users to define their own sockopts, instead of needing to make a PR to Nix for every single one. Fixes nix-rust#577
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
src/sys/socket/sockopt.rs
Outdated
use $crate::sys::socket::sockopt::Get; | ||
let mut getter: $getter = | ||
$crate::sys::socket::sockopt::Get::uninit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This allows users to define their own sockopts, instead of needing to make a PR to Nix for every single one.
Fixes #577
What does this PR do
Checklist:
CONTRIBUTING.md