-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow custom HMR configuration #404
base: main
Are you sure you want to change the base?
feat: allow custom HMR configuration #404
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 6cb0bf9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@vinxi/deno-doc
vinxi
@vinxi/plugin-directives
@vinxi/doc
@vinxi/plugin-mdx
@vinxi/openapi
@vinxi/react
@vinxi/react-server
@vinxi/router
@vinxi/server-components
@vinxi/server-functions
@vinxi/solid
commit: |
I am unsure whether this works as the vite config is not passed into |
We create several instances of vite, based on how many routers are created, and they each need a unique HMR port, thus by default we randomize it. We could allow people to specify the hmr port for a given router, but we can't really do one HMR port for the whole app |
sounds good, a port per router |
fixes #394