Add openssl error info #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void openssl_res_err(int result, char* where) { | ||
| if (result != 0) { | ||
| printf("Failed '%s': %d - %s\n", where, result, ERR_reason_error_string(ERR_get_error())); | ||
| exit(0); |
There was a problem hiding this comment.
Do we need to exit here?
Maybe it's useful to proceed and see what happens afterwards.
There was a problem hiding this comment.
With my 0094, it can reach the menu:
1 - Scan fingerprint
2 - Test leds
0 - Exit
But none of them works. The device replies with 0404.
I think the exit may still be necessary to guarantee a proper process.
There was a problem hiding this comment.
It's necessary to have a EC_KEY_check_key there and fail it if the private key not suitable, because I did a workaround during the parse of private key, which may lead some errors...
Before doing that, the header check and the padding check for the private key always failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add macro and function to display openssl error info.
Before, during my debug, while private key validation failed, it shows:
It may mislead someone who is debugging on the device.
Now it can show the right error information: