Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getVertexPositions as template function #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brezhnyev
Copy link

No description provided.

@nmwsharp
Copy link
Owner

nmwsharp commented Jun 1, 2020

Hi! Thank you for the pull request.

This seems reasonable, though can you add a default version so that existing code that just calls getVertexPositions() still works? Perhaps something like:

std::vector<std::array<double, 3>> getVertexPositions(
    const std::string& vertexElementName = "vertex") {

    return getVertexPositions<double>(vertexElementName);

}

(I feel like there ought to be some way to do this with a typedef/using, but I don't know what it is)

This should also get the CI test above to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants