Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common case helper for texture UVs added #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

common case helper for texture UVs added #8

wants to merge 1 commit into from

Conversation

EgeCiklabakkal
Copy link

No description provided.

@nmwsharp
Copy link
Owner

Hi, thanks for opening this pull request!

I totally support the adding these UV common-case helpers, but I think a few changes might be needed compared with this strategy.

  • If there are no UV properties, we should throw an error. This might not be the best behavior, but it should be consistent with other functions like getVertexColor()
  • All-zero UVs probably shouldn't get special treatment in the library, that can be handled in the user's application
  • We should probably check a few common names for UV's, I've seen s and t as well for instance.

@fire
Copy link

fire commented Jan 19, 2022

Is this pr salvageable? Can you propose tasks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EgeCiklabakkal @nmwsharp @fire