-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ml service] Move the duplicated structure and functions of the extension_service and training_offloading_services to ml_service. #573
Conversation
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #573. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
cibot: @songgot, The last line of a text file must have a newline character. Please append a new line at the end of the line in c/src/ml-api-service.c. |
To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself. |
099bb0d
to
0296526
Compare
cibot: @songgot, The last line of a text file must have a newline character. Please append a new line at the end of the line in c/src/ml-api-service-training-offloading.c. |
0296526
to
53309ba
Compare
cibot: @songgot, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/573-202410311110060.56479692459106-53309baeb2f84709dd33158db407346481fa1632/. |
To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself. |
5f863d2
to
2fb81d0
Compare
To contributor, We have used 'Signed-off-by:' notation by default to handle the license issues, that result from contributors. Note that 'Is there a Signed-off-by line?' is important because lawyers tell us we must have to it to cleanly maintain the open-source license issues even though it has nothing to do with the code itself. |
af88ca0
to
f6edc64
Compare
ce4af6c
to
8516652
Compare
- Training offloading start function is separated into prepare_sender and preapre_receiver - Change mix used variable name - ml_pipeline_start is commonly used in start functions Signed-off-by: hyunil park <[email protected]>
5449eea
to
b0c5350
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@songgot, 💯 All CI checkers are successfully verified. Thanks.
b0c5350
to
710d5dc
Compare
8206a1f
to
17991a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@songgot, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, comments that describe the functions are required to be revised.
…sion_service and training_offloading_services to ml_service. - Remove _ml_extension_invoke_new_data(), _invoke_event_new_data() - Remove ml_extension_node_type_e, ml_extension_node_info_s - Remove ml_training_offloading_node_type_e, ml_training_offloading_node_info_s - Remove _ml_extension_pipeline_sink_cb(), _pipeline_sink_cb() - Create _ml_service_invoke_event_new_data() - Create ml_service_node_type_e, ml_service_node_info_s - Create _ml_service_pipeline_sink_cb() - Code clean: Change mix used variable name Signed-off-by: hyunil park <[email protected]>
17991a2
to
cbe8953
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@songgot, 💯 All CI checkers are successfully verified. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[ml service] Code clean & Refactoring
[ml service] Move the duplicated structure and functions of the extention_service and training_offloading_services to ml_service.
Pull Up Method : https://refactoring.guru/ko/pull-up-method
Pull Up Field : https://refactoring.guru/ko/pull-up-field
Duplicate Code: https://refactoring.guru/ko/smells/duplicate-code