[Build/Pkg] Rename spec and manifest files #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
again4you
requested review from
myungjoo,
jijoongmoon,
jaeyun-jung,
wooksong,
gichan-jang,
anyj0527,
songgot,
niley7464 and
yeonykim2
as code owners
gichan-jang
reviewed
Jan 25, 2024
jaeyun-jung
reviewed
Jan 25, 2024
again4you
force-pushed
the
dev/update_spec
branch
from
d4dc21c
to
a85717b
Compare
again4you
force-pushed
the
dev/update_spec
branch
3 times, most recently
from
925ef64
to
4a3c8d6
Compare
jaeyun-jung
reviewed
Feb 7, 2024
jaeyun-jung
approved these changes
Feb 7, 2024
again4you
force-pushed
the
dev/update_spec
branch
from
4a3c8d6
to
b4f4df3
Compare
wooksong
reviewed
Feb 7, 2024
wooksong
reviewed
Feb 7, 2024
wooksong
reviewed
Feb 7, 2024
wooksong
reviewed
Feb 7, 2024
again4you
force-pushed
the
dev/update_spec
branch
2 times, most recently
from
4f3e960
to
388e5f6
Compare
jaeyun-jung
reviewed
Feb 8, 2024
jaeyun-jung
reviewed
Feb 8, 2024
| %license LICENSE | ||
| %attr(0755,root,root) %{test_base_dir}/machine-learning-agent-test | ||
| %attr(0755,root,root) %{test_base_dir}/mlops-agent-test |
There was a problem hiding this comment.
need fix 'test_base_dir'
%define test_base_dir %{_bindir}/mlops-agent-test
or
%define test_base_dir %{_bindir}/ml-test
then in file /tests/meson.build
test_base_dir = join_paths(.. , 'mlops-agent-test' or 'ml-test')
There was a problem hiding this comment.
I am going to use ml. Thanks
There was a problem hiding this comment.
jaeyun-jung
reviewed
Feb 8, 2024
| %{test_base_dir}/unittests | ||
| %{_libdir}/libml-agent-test.a | ||
| %{_libdir}/libml-agent-test.so* | ||
| %{_libdir}/libmlops-agent-test.a |
There was a problem hiding this comment.
should we include libmlops-agent-test library here?
suggestion at line 116 (update require mlops-agent > mlops-agent-test)
%package unittests
....
Requires: mlops-agent = %{version}-%{release} > mlops-agent-test = %{version}-%{release}
again4you
force-pushed
the
dev/update_spec
branch
from
388e5f6
to
ae04696
Compare
This patch renames spec and manifest files to mlops-agent.spec and mlops-agent.manifest. It also update the package name with the'mlops-agent'. However, the name of D-Bus service is not changed since this channel is also used as Service API. Signed-off-by: Sangjung Woo <[email protected]>
again4you
force-pushed
the
dev/update_spec
branch
from
ae04696
to
ea79f19
Compare
wooksong
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames spec and manifest files to
mlops-agent.specandmlops-agent.manifest.Self evaluation:
Submit History
V4
V3
V2
mlops-agent. It can cause the image creation error but it is more clear.org.tizen.machinelearning.servicesince this service also used as Service API.V1