Dist/Tizen: Clean up the RPM spec file #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a trivial patch for cleaning up the Tizen RPM spec file. Instead of the hard-coded string for build directory, this patch updates it to the RPM spec macro. Signed-off-by: Wook Song <[email protected]>
This patch adds the omitted wiping-out of the build directory before the configuration of this project. Signed-off-by: Wook Song <[email protected]>
This patch replaces the lines directly using ninja in the build and install sections with the meson's compile and install commands. Signed-off-by: Wook Song <[email protected]>
wooksong
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
gichan-jang,
anyj0527,
songgot,
niley7464 and
yeonykim2
as code owners
jaeyun-jung
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to applying the commits that enable
ml-agent-test, this PR has been submitted to address the following commits:Signed-off-by: Wook Song [email protected]