Report STALE when there is at least one STALE and no ERROR #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timple
reviewed
Apr 18, 2023
| @@ -310,9 +310,12 @@ void Aggregator::publishData() | |||
|
|
|||
| agg_pub_.publish(diag_array); | |||
|
|
|||
| // Top level is error if we have stale items, unless all stale | |||
There was a problem hiding this comment.
This sounds like a design choice.
Would you mind opening a similar PR on the official repo? Or an issue.
Perhaps for the ROS2 as ROS1 seems unmaintained.
There was a problem hiding this comment.
I've opened a discussion: ros#297
Rayman
force-pushed
the
feature/HARVEY-1380-new-analyser-group
branch
from
b18c79b
to
ef48cc6
Compare
MCFurry
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've modified both the analyzer_group and the aggregator.