ISSUE-1480 Deleting temporary _MEI files #1978
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monorimet
previously approved these changes
Dec 5, 2023
|
Thank you very much! I've made the formatting changes as requested using black and have pushed the updates. |
|
This is going to be lost in the switch to SHARK-2.0 as it targets the old app code. We should add this as a follow-up to the beta release. If you want to land this patch, we should be able to merge it into the SHARK-1.0 branch without conflicts. Otherwise, might need to wait for #2037 as it handles most of the app reimplementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I resolved issue 1480, which is associated with deleting temporary _MEI files. I was unable to find the file containing the unit tests for index.py, so I created a new one. If such a file already exists, please let me know where it is, and I will transfer the tests there.