Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tuner] Add CI for all tuning PR #88

Merged
merged 26 commits into from
Aug 7, 2024
Merged

[tuner] Add CI for all tuning PR #88

merged 26 commits into from
Aug 7, 2024

Conversation

RattataKing
Copy link
Contributor

@RattataKing RattataKing commented Aug 1, 2024

  • Add pre-commit.yml and pytest.yml
  • Remove test_walk_mlir_op() in test_tune.py, which has dependencies on iree compiler, and its test data (template input mlir) is hard to maintain
  • Remove test-data contents

@RattataKing RattataKing force-pushed the add_ci_remote branch 3 times, most recently from e70c329 to 93d1177 Compare August 1, 2024 22:09
@RattataKing RattataKing changed the title [tuner] Enable pre-commit test for all branches and PR [tuner] Enable pre-commit test for all PR Aug 1, 2024
@RattataKing RattataKing changed the title [tuner] Enable pre-commit test for all PR [tuner] Run pre-commit test for all PR Aug 1, 2024
.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
.github/workflows/pre-commit.yml Show resolved Hide resolved
@RattataKing RattataKing changed the title [tuner] Run pre-commit test for all PR [tuner] Add CI for all tuning PR Aug 2, 2024
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
@RattataKing RattataKing requested a review from kuhar August 2, 2024 22:19
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's wait for @ScottTodd to approve

.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
.github/workflows/pytest.yml Outdated Show resolved Hide resolved
@kuhar kuhar self-requested a review August 6, 2024 16:04
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you paste a link to a successful run on of this workflow on your fork?
Ah no, I can see it actually ran here already but failed.

Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflows LGTM after changing * to **. Probably want the tests to pass before merging this.

.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
Copy link
Member

@kuhar kuhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed, LGTM

@kuhar kuhar merged commit 4b8aa30 into main Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants