Skip to content

Commit

Permalink
See if stale dependencies are causing shortfin server to fail to start (
Browse files Browse the repository at this point in the history
#604)

# Description

We started seeing a failure in `Shortfin CPU LLM Integration Test` after
merging #601. However, the only aspect of the integration test that that
PR touches is a fix in the logger:

Old
```python
logger = logging.getLogger("__name__")
```

New
```python
logger = logging.getLogger(__name__)
```

That shouldn't have an impact on the test, and while reading the output
of the workflow, it didn't seem to be the line that caused the server to
not start.

When testing locally in a fresh environment, the test ran fine, which
made me think that it may be related to stale dependencies. I updated
the hash of cached pip to take into account requirement changes in
`sharktank` and `shortfin`, which appears to fix the test.
  • Loading branch information
stbaione authored Nov 25, 2024
1 parent bf8540f commit e906b66
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci-shark-ai.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
id: cache-pip
with:
path: ${{ env.PIP_CACHE_DIR }}
key: pip-${{ steps.setup_python.outputs.python-version }}-${{ hashFiles('*requirements.txt') }}
key: pip-${{ steps.setup_python.outputs.python-version }}-${{ hashFiles('*requirements*.txt','shortfin/requirements*.txt','sharktank/requirements*.txt') }}

- name: Install pip deps
run: |
Expand Down

0 comments on commit e906b66

Please sign in to comment.