Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh metadata in sharktank/setup.py. #247

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Refresh metadata in sharktank/setup.py. #247

merged 2 commits into from
Oct 15, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Oct 3, 2024 •
edited
Loading

  • Drop author email for consistency with shortfin (we could also pick a mailing list or more up to date contact email)
  • Update URL following repository rename

More will be needed as we add a dep on shortfin and resume regular publishing of this sharktank package to https://pypi.org/project/sharktank/

sogartar
sogartar approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@sogartar sogartar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI workflows would also need an update.

@ScottTodd ScottTodd merged commit ffee822 into nod-ai:main Oct 15, 2024
8 checks passed
@ScottTodd ScottTodd deleted the sharktank-package-metadata branch October 15, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogartar sogartar sogartar approved these changes

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ScottTodd @sogartar