Add reporting for llama testing and improve error handling #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saienduri
changed the title
| @@ -256,3 +256,23 @@ def get_iree_flags(request: FixtureRequest): | |||
| model_path["iree_hal_target_backends"] = set_fixture_from_cli_option( | |||
| request, "--iree-hal-target-backends", "iree_hal_target_backends" | |||
| ) | |||
|
|
|||
|
|
|||
| def pytest_html_results_table_header(cells): | |||
There was a problem hiding this comment.
Do you use these functions anywhere?
Nit: Maybe a small comment to what the functions are doing.
There was a problem hiding this comment.
Added a comment. Yeah, these functions allow us to customize the html reports and add the XFail Reason column in the https://nod-ai.github.io/SHARK-Platform.
aviator19941
approved these changes
Oct 30, 2024
marbre
reviewed
Oct 31, 2024
| - name: Deploy to GitHub Pages | ||
| uses: peaceiris/actions-gh-pages@v3 | ||
| with: | ||
| github_token: ${{ secrets.SHARK_PLATFORM_GH_TOKEN }} |
There was a problem hiding this comment.
This broke the CI for PRs from forks, see #395. Sending a PR to deactivate this until fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit generates reports for the llama testing. Every time it runs it in CI, it will deploy to github pages (https://nod-ai.github.io/SHARK-Platform). @aviator19941 is working on getting the rest of the tests properly implemented. Only the llama8b fp16 tests are working as intended at the moment.