Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow cleanup: move checkout to start, prune unused steps+vars. #639

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Dec 3, 2024

Cutting down on boilerplate and standardizing some workflow syntax before deeper refactoring work.

@ScottTodd ScottTodd marked this pull request as ready for review December 3, 2024 21:45
Copy link
Contributor

@stbaione stbaione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test failures for perplexity short and Llama Benchmarking are due to #638, not anything with this PR

@ScottTodd ScottTodd merged commit 7eccb76 into nod-ai:main Dec 3, 2024
16 of 20 checks passed
@ScottTodd ScottTodd deleted the workflow-cleanup branch December 3, 2024 22:20
@ScottTodd
Copy link
Member Author

Ah. Thanks for noticing. Sent #642

ScottTodd added a commit that referenced this pull request Dec 4, 2024
Missed these as part of #639 (too
many workflows 😵 )
Copy link
Collaborator

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants