Shortfin LLM Debug Ergonomics: one flag to dump them all #668
+239
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
changed the title
stbaione
reviewed
Dec 10, 2024
ScottTodd
reviewed
Dec 10, 2024
renxida
force-pushed
the
sfllmdebugdump
branch
from
6c9d802 to
dfd2416
Compare
stbaione
approved these changes
Dec 10, 2024
ScottTodd
reviewed
Dec 11, 2024
renxida
force-pushed
the
sfllmdebugdump
branch
from
dfd2416 to
e6b5eeb
Compare
…ch vmfb Program invocation
… interface a little; remove catch-all try statement because if we're not debugging we won't need it and if we're debugging we don't want the debugging code to fail silently when loglevel doesn't output info messages
renxida
force-pushed
the
sfllmdebugdump
branch
from
e6b5eeb to
5c9c6dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @stbaione for originally writing a lot of the debug code in here. I organized his debug logging & dumping into a separate file & made the output easier to deal with.