Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added convenience scripts et. al. #6

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

eLoyyyyy
Copy link

Thanks for this wonderful starter project. I had trouble setting it up as it is (Initially the qode dependencies, but after that all of the commands needed to get started). So I want to suggest these changes for this project. Some are non-essentials and others (npm scripts) are essential for me because of the commands are:

  1. scattered across multiple projects
  2. are referencing globally installed modules, i.e. webpack.

Still, thanks for the starter project.

Copy link

@jswhisperer jswhisperer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR should ideally only contain the package.json I think, not all the config files

@eLoyyyyy
Copy link
Author

got it @gregpalaci ! Would you like me to make a separate PR for the other files? Those files are, I think, the norm on all vue projects.

@eLoyyyyy eLoyyyyy force-pushed the refactor/vue-update branch 2 times, most recently from e398f4e to 013059e Compare May 10, 2021 02:37
eLoyyyyy added 8 commits May 10, 2021 10:44
- change package-lock to yarn lock
- modify webpack dependency to devdependency because webpack being installed as a dependency, webpack bin file is not found within the project
…g nodegui-packer on the same project so you don't need npx
@eLoyyyyy eLoyyyyy force-pushed the refactor/vue-update branch from 013059e to 6491dc8 Compare May 10, 2021 02:45
@eLoyyyyy
Copy link
Author

For the update, I retained the lock files and the package.json. Let me know if this is okay with you @gregpalaci .

@jswhisperer
Copy link

Sorry for the tardy reply I'm 100% with that, can kill my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants