Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to use common wasm builder #113

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Nov 13, 2024

This is the second attempt. Changes from the first version include:

  • no longer need to pass --docker when running tools/build-wasm.js so that any existing references (like in the action to update swc will work without needing any changes)
  • mapping in a working directory. This is needed when not running as user 1000 (the user specified in the container) as since we are mapping directories into the contoainer the current user is specified and that means that writting to directories in the container won't necessarily work. The current user is often 1000 on single user vms as its the default for the first user but is is not the case otherwise and is not the case when running under actions.

I ran the swc update action here after pushing some additional commits to change the swc version so an update would be done - https://github.com/mhdawson/amaro/actions/runs/11808426410https://github.com/mhdawson/amaro/actions/runs/11808426410

The action ran successfully and created the PR for the swc update.

- second attempt

Signed-off-by: Michael Dawson <[email protected]>
@marco-ippolito marco-ippolito merged commit 818ed8e into nodejs:main Nov 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants