Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(git-node): verify tag signature during release promotion #879

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 10, 2024

Before pushing the tag upstream, we can verify if it's signed with a known identity (name+email address+key combo), as the releaser might be relying on a mailmap entry, which are typically not used when verifying a tag signature (at least not by GitHub web UI).

/cc @nodejs/releasers

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.08%. Comparing base (e90258c) to head (924994c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #879   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          39       39           
  Lines        4676     4676           
=======================================
  Hits         3745     3745           
  Misses        931      931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aduh95 aduh95 merged commit 4bd6820 into nodejs:main Dec 20, 2024
13 checks passed
@aduh95 aduh95 deleted the verify-tag-signature branch December 20, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants