test_runner: separate option validation logic from run function

nodejs · Dec 2, 2024 · 4f3b8ad · 4f3b8ad
1 parent 61e4ad5
commit 4f3b8ad
Showing 1 changed file with 56 additions and 1 deletion.
diff --git a/lib/internal/test_runner/runner.js b/lib/internal/test_runner/runner.js
@@ -535,7 +535,7 @@ function watchFiles(testFiles, opts) {
   return filesWatcher;
 }
 
-function run(options = kEmptyObject) {
+function validateAndSetDefaultOptions(options) {
   validateObject(options, 'options');
 
   let {
@@ -664,6 +664,61 @@ function run(options = kEmptyObject) {
   validateStringArray(argv, 'options.argv');
   validateStringArray(execArgv, 'options.execArgv');
 
+  return {
+    __proto__: null,
+    testNamePatterns,
+    testSkipPatterns,
+    shard,
+    coverageExcludeGlobs,
+    coverageIncludeGlobs,
+    concurrency,
+    timeout,
+    signal,
+    files,
+    forceExit,
+    inspectPort,
+    isolation,
+    watch,
+    setup,
+    only,
+    globPatterns,
+    coverage,
+    lineCoverage,
+    branchCoverage,
+    functionCoverage,
+    execArgv,
+    argv,
+    cwd,
+  };
+}
+
+function run(options = kEmptyObject) {
+  const {
+    testNamePatterns,
+    testSkipPatterns,
+    shard,
+    coverageExcludeGlobs,
+    coverageIncludeGlobs,
+    concurrency,
+    timeout,
+    signal,
+    files,
+    forceExit,
+    inspectPort,
+    isolation,
+    watch,
+    setup,
+    only,
+    globPatterns,
+    coverage,
+    lineCoverage,
+    branchCoverage,
+    functionCoverage,
+    execArgv,
+    argv,
+    cwd,
+  } = validateAndSetDefaultOptions(options);
+
   const rootTestOptions = { __proto__: null, concurrency, timeout, signal };
   const globalOptions = {
     __proto__: null,