-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: ensure CryptoKey usages and algorithm are cached objects #56108
Open
panva
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
panva:ensure-cached-slots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+51
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
|
panva
added
request-ci
Add this label to start a Jenkins CI on a PR.
web-standards
Issues and PRs related to Web APIs
labels
Dec 2, 2024
cc @nodejs/web-standards |
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56108 +/- ##
==========================================
+ Coverage 87.96% 88.00% +0.03%
==========================================
Files 656 656
Lines 188383 188981 +598
Branches 35975 35993 +18
==========================================
+ Hits 165716 166308 +592
+ Misses 15842 15832 -10
- Partials 6825 6841 +16
|
KhafraDev
approved these changes
Dec 2, 2024
panva
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
web-standards
Issues and PRs related to Web APIs
webcrypto
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the spec both the
usages
andalgorithm
are "cached", i.e. not new objects every time the getter is invoked.This fixes the behaviour for
usages
and adds tests for both.