Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update WPT for url to 6fa3fe8a92 #56136

Merged
merged 4 commits into from
Dec 10, 2024
Merged

test: update WPT for url to 6fa3fe8a92 #56136

merged 4 commits into from
Dec 10, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of the WPT for url to web-platform-tests/wpt@6fa3fe8.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 5, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Dec 5, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.50%. Comparing base (ac7fea6) to head (516ec93).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56136      +/-   ##
==========================================
+ Coverage   88.01%   88.50%   +0.49%     
==========================================
  Files         656      656              
  Lines      189136   189261     +125     
  Branches    36004    36346     +342     
==========================================
+ Hits       166461   167511    +1050     
+ Misses      15842    14966     -876     
+ Partials     6833     6784      -49

see 95 files with indirect coverage changes

@anonrig
Copy link
Member

anonrig commented Dec 5, 2024 •
edited
Loading

URL specification recently changed to Unicode 15.1 where the new tests are only passing for 2 browsers/runtimes. Ada isn't one of them yet. WHATWG plans to update Unicode to 16 on February. I'm not sure if it's worth fixing this now, and do a larger update on February.

cc @nodejs/tsc for visibility

@anonrig anonrig added the blocked PRs that are blocked by other issues or PRs. label Dec 5, 2024
@aduh95
Copy link
Contributor

aduh95 commented Dec 5, 2024

/cc @nodejs/web-standards

@targos targos force-pushed the actions/update-wpt-url branch from 0046233 to f51c387 Compare December 8, 2024 10:02
@aduh95 aduh95 added semver-major PRs that contain breaking changes and should be released in the next major version. and removed blocked PRs that are blocked by other issues or PRs. semver-major PRs that contain breaking changes and should be released in the next major version. labels Dec 8, 2024
@aduh95
Copy link
Contributor

aduh95 commented Dec 8, 2024

It looks like some of our own tests uses WPT fixtures and are therefor impacted

@anonrig
Copy link
Member

anonrig commented Dec 8, 2024

It looks like some of our own tests uses WPT fixtures and are therefor impacted

Yes, I think we should remove it. That test depends on ada to_ascii and to_unicode functions but we already test it inside the URL parser. There is no need to have an additional test specifically for it.

@targos targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 9, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 9, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63953/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/63962/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7443a28 into main Dec 10, 2024
68 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 7443a28

@nodejs-github-bot nodejs-github-bot deleted the actions/update-wpt-url branch December 10, 2024 00:36
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@nodejs-github-bot @aduh95
test: update WPT for url to 6fa3fe8a92
a0c4a5f 
PR-URL: #56136
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nodejs-github-bot @anonrig @aduh95 @targos