Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase spin for eventloop test on s390 #56228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Dec 11, 2024

It was excluded as it was failing intermittently. Likely that s390 was just so fast times were rounded down to 0.

Refs: #41286

Increase the spin time on s390x only.

Stress run of 1000 with no failures with this change - https://ci.nodejs.org/job/node-stress-single-test/nodes=rhel8-s390x/548/console

It was excluded as it was failing intermittently. Likely
that s390 was just so fast times were rounded down to 0.

Increase the spin time on s390x only.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Dec 11, 2024
@lpinca
Copy link
Member

lpinca commented Dec 11, 2024

Does the test still fail without increasing the spin time? I wonder if anything has changed since the test was marked flaky.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (f184a0a) to head (f9562c9).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56228      +/-   ##
==========================================
- Coverage   88.53%   88.53%   -0.01%     
==========================================
  Files         657      657              
  Lines      189858   189885      +27     
  Branches    36450    36452       +2     
==========================================
+ Hits       168089   168109      +20     
- Misses      14973    14989      +16     
+ Partials     6796     6787       -9     

see 44 files with indirect coverage changes

@mhdawson
Copy link
Member Author

@lpinca I had looked at the test code and nothing changed since the issue was opened. Here is a run on main - https://ci.nodejs.org/view/Stress/job/node-stress-single-test/550/

@lpinca
Copy link
Member

lpinca commented Dec 11, 2024

I was referring to the actual code being tested, but I see one failure in the stress test on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants