fix: add node prefix for util to fix issue in env with min version node 18

[riderx]

This relates to

I found 3 old issues talking about this:
#1992
#2015
#1541
Where it talks mainly about anterior version of Node.js before 18.
So my assumption if this import was maybe forgotten to get the prefix, I'm aware that can be wrong, but since that the only blocker for Cloudflare use case I try to bring this

Rationale

I use undici in Cloudflare workers with Node.js support, it only supports new package nomenclature, and it seems only these 2 imports are malformed compared to all other imports

Changes

Add node: prefix missing for util/types

Features

No new features

Bug Fixes

This fix undici for Cloudflare wrangler config with

compatibility_flags = [ "nodejs_compat" ]

Breaking Changes and Deprecations

None since we already requested Node.js 18 min.

Status

It passed all tests on Node.js 18

• I have read and agreed to the Developer's Certificate of Origin
• Tested
• [s] Benchmarked (optional)
• [s] Documented
• Review ready
• In review
• Merge ready

[riderx]

Result of npm run test on Node.js 18

I have read the contribution file, and I'm not sure to understand the relation between this repo and the Wasm lib instructions.
When I check out a tag, there is no package.json in the code, so I cannot build I would use the files but I'm not even sure what tag i should use.
I would like to get more clarified about the purpose of this for the contribution.

[Uzlopak]

LGTM

[Uzlopak]

When I added the node prefix i actually missed it.

Can you maybe also do following changes?
test/websocket/messageevent.js line 4
test/fetch/pull-dont-push.js line 6 - 9

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e39a632) 85.54% compared to head (26750f1) 85.34%.
Report is 316 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    cloudflare/workers-sdk#2775      +/-   ##
==========================================
- Coverage   85.54%   85.34%   -0.21%     
==========================================
  Files          76       85       +9     
  Lines        6858     7600     +742     
==========================================
+ Hits         5867     6486     +619     
- Misses        991     1114     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mcollina]

lgtm

[mcollina]

As a side note, I'm not convinced this runs in workerd/cloudflare workers.

[riderx]

@Uzlopak thanks, I made the change!
Honestly, I didn't expect so many reviews on a Sunday, thanks a lot!

[Uzlopak]

Thank you

[riderx]

@mcollina I did try my change on workers and there is still one issue, but it's not linked to Undici, it's an error in workers :
cloudflare/workerd#1711
I believe if they fix it, Undici will work with the flag.
I tried to run the jest test in miniflare following this:
https://miniflare.dev/testing
and this:
https://legacy.miniflare.dev/testing/jest
and by add this locally to the jest config:

  "jest": {
    "testEnvironment": "miniflare",
    "testMatch": [
      "<rootDir>/test/jest/**"
    ]
  },

And npm install -D jest-environment-miniflare jest

But it seems performance is not implemented and miniflare v2 is deprecated, so we cannot ensure for now it will pass the test in Cloudflare workers, and just let adventurous people like me try it in project

[mcollina]

I don't think it will, and I'm not 100% why you'd like to do this. This module will try to open a new socket and manage a connection pool.

workers already offer their kmplementation of fetch(), which is definitely more optimized for their environment. Why would you need to use this instead?

[riderx]

Agree my usecase is a bit special.
My original code is in Deno, and with the import map of Deno and package.json was able to to replicate my serverless function in many envs.
Netlify functions
Netlify edge.
AWS lambda
cloudflare workers.
Lately I switched from custom implementations for S3 to a package made originally for Deno.

And I ported this package with Deno dnt to NPM.
You can see it here:

bradenmacdonald/s3-lite-client#30

One of my try was to use Undici shim to make it run, it worked on Node but not on workers.

now the final solution is a dynamic import who work everywhere.

i really like the idea in the future the same code will be able to run anywhere, just based on some config differences.

[mcollina]

lgtm