-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch: don't use pooled buffer in body mixin #3377
fetch: don't use pooled buffer in body mixin #3377
Conversation
@mcollina |
I think there's still some questions left to answer here. Mostly: is this something we need? If not (and I am assuming we don't), what benefit is there in adding it? |
I also have my doubts. but, double cloning can be avoided, as in the commit just added. In fact, it is not skipping the spec, but creating a new arraybuffer at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not interested in any solution that changes around the steps in the spec
Hmm... If I was to say it, It is completely fix #3337, but we may not need to worry about pooled buffer. |
completely fix #3337