[Backport v6.x] web: mark as uncloneable when possible (#3709) #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* web: mark as uncloneable when possible This tells node that the marked instances from undici are not cloneable, so that attempts to cloning those throw `DataCloneError`. * test: add test cases for platform objects uncloneable * fix: move to webidl * fix: move it under webidl * fixup: rename it to markAsUncloneable * fix: mark more web instances uncloneable * fixup --------- Co-authored-by: Khafra <[email protected]> (cherry picked from commit 1ab2382)
jazelly
force-pushed
the
backport-3709-to-v6.x
branch
from
9ce24c7
to
429d59c
Compare
Ethan-Arrowood
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tells node that the marked instances from undici are not cloneable, so that attempts to cloning those throw
DataCloneError.test: add test cases for platform objects uncloneable
fix: move to webidl
fix: move it under webidl
fixup: rename it to markAsUncloneable
fix: mark more web instances uncloneable
fixup
Co-authored-by: Khafra [email protected]
(cherry picked from commit 1ab2382)
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status