Fixed: Incorrect default value of maxEntries for MemoryCache #904 #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11744442717Details
💛 - Coveralls |
|
could you add a test that checks that the value is what is expected? |
Fixed: do not remove items from cache upon updating existing key.
|
Sure, I've extended coverage for internal cache. And while doing so spotted that the oldest cache entry will be purged upon updates of existing keys too. Probably not a real issue, but it might lead to some head-scratching when someone is using the cache with a strict and fixed set of values. So fixed that. |
daan944
pushed a commit
to daan944/opossum
that referenced
this pull request
Nov 20, 2024
* main: chore(main): release 8.3.1 (nodeshift#907) fix: Incorrect default value of maxEntries for MemoryCache nodeshift#904 (nodeshift#906) # Conflicts: # lib/cache.js
daan944
pushed a commit
to daan944/opossum
that referenced
this pull request
Nov 20, 2024
Merge branch 'main' into coalesce-reset-options * main: chore(main): release 8.3.1 (nodeshift#907) fix: Incorrect default value of maxEntries for MemoryCache nodeshift#904 (nodeshift#906) # Conflicts: # lib/cache.js
lholmquist
pushed a commit
that referenced
this pull request
Nov 27, 2024
… success, timeout) (#908) * Feature: option to reset coalesce depending on result of action. * Fix: Don't crash when coalescing is disabled. * Bugfix: Fix max size for cache entries. * Fixed error whilst merging, accidentally removed cache delete function Merge branch 'main' into coalesce-reset-options * main: chore(main): release 8.3.1 (#907) fix: Incorrect default value of maxEntries for MemoryCache #904 (#906) # Conflicts: # lib/cache.js * Docs: Update readme with coalesceResetOn and Fetch example. --------- Co-authored-by: Daan <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #904