Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement auth without the OpenID Connect Gem #253

Merged
merged 12 commits into from
Apr 12, 2020
Merged

implement auth without the OpenID Connect Gem #253

merged 12 commits into from
Apr 12, 2020

Conversation

CrowdHailer
Copy link
Contributor

@CrowdHailer CrowdHailer commented Mar 30, 2020 •
edited
Loading

Tackles issue #124

Working authentication.
Remaining steps:

  • Handle errors
  • Fix button styles
  • Environment variables for client_id/secret
  • is Faraday Gem ok for HTTP client

@nodunayo
Copy link
Owner

nodunayo commented Apr 7, 2020 •
edited
Loading

Todo:

  • Require auth on editing submissions
  • Set up new DID app for staging and prod

CrowdHailer
CrowdHailer commented Apr 12, 2020
View reviewed changes
app/controllers/session_controller.rb
if Rails.env == "test"
session[:current_user_id] = "123"
redirect_to root_path
return
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple way to group the test check away from main logic, I like it.

@nodunayo nodunayo merged commit c28be75 into nodunayo:master Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CrowdHailer @nodunayo