Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: Require types of globals to be specified #6592

Merged
merged 6 commits into from
Nov 22, 2024
Merged

chore!: Require types of globals to be specified #6592

merged 6 commits into from
Nov 22, 2024

Conversation

michaeljklein
Copy link
Contributor

Description

Problem*

Resolves global type inference issues in #6469

Summary*

The approach in #6469 is to evaluate all globals as comptime globals, but that interacts poorly with polymorphic types, e.g. the type of x in let x = 3.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

michaeljklein and others added 2 commits November 21, 2024 19:23
@michaeljklein
require global types to be specified, add error that's thrown when un…
80b593c 
…specified and is_unspecified check for UnresolvedType(Data), update tests and add new unit tests for this behavior
@michaeljklein
Merge branch 'master' into michaeljklein/require-global-type
b1b721e
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024 •
edited
Loading

🚀 Deployed on https://6740e461f74a113dddd143db--noir-docs.netlify.app

michaeljklein and others added 2 commits November 22, 2024 13:11
@michaeljklein
Merge branch 'master' into michaeljklein/require-global-type
ecc06dc
@michaeljklein
use 'contains_unspecified' instead of is_unspecified to recursively c…
dd9bd09 
…heck for Unspecified, update tests, move WILDCARD_TYPE to ast/statements where it's now used with Path
jfecher
jfecher approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an error message suggestion

compiler/noirc_frontend/src/hir/resolution/errors.rs Outdated Show resolved Hide resolved
compiler/noirc_frontend/src/tests.rs Outdated Show resolved Hide resolved
@michaeljklein michaeljklein added this pull request to the merge queue Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

FYI @noir-lang/developerrelations on Noir doc changes.

Merged via the queue into master with commit 8ff4efd Nov 22, 2024
49 checks passed
@michaeljklein michaeljklein deleted the michaeljklein/require-global-type branch November 22, 2024 20:14
@noirwhal noirwhal mentioned this pull request Nov 22, 2024
Open
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 23, 2024
@AztecBot
[1 changes] feat: Add array_refcount and slice_refcount builtins …
8719b3b 
…for debugging (noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 23, 2024
@AztecBot
feat: Add array_refcount and slice_refcount builtins for debugging (
ee7a338 
noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
@AztecBot AztecBot mentioned this pull request Nov 23, 2024
Open
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 24, 2024
@AztecBot
[1 changes] feat: Add array_refcount and slice_refcount builtins …
88c2f3d 
…for debugging (noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Nov 24, 2024
@AztecBot
feat: Add array_refcount and slice_refcount builtins for debugging (
d20740f 
noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

@TomAFrench TomAFrench Awaiting requested review from TomAFrench

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeljklein @jfecher @TomAFrench