Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test PR merging #6585 and #6577 #6607

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

chore: test PR merging #6585 and #6577 #6607

wants to merge 20 commits into from

Conversation

jfecher
Copy link
Contributor

@jfecher jfecher commented Nov 22, 2024

Description

Problem*

Resolves

Summary*

Merges #6585 and #6577 to see opcode count differences.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jfecher jfecher changed the title Chore: test PR merging #6585 and #6577 chore: test PR merging #6585 and #6577 Nov 22, 2024
Copy link
Contributor

Changes to Brillig bytecode sizes

Generated at commit: a8a76baa85ec4a781e0f12c9d62f3be427628476, compared to commit: 45eb7568d56b2d254453b85f236d554232aa5df9

🧾 Summary (10% most significant diffs)

Program Brillig opcodes (+/-) %
nested_array_dynamic +378 ❌ +18.98%
nested_array_in_slice +181 ❌ +15.08%
brillig_rc_regression_6123 +24 ❌ +13.41%
nested_dyn_array_regression_5782 +15 ❌ +8.98%
regression_struct_array_conditional +44 ❌ +8.22%
brillig_nested_arrays +11 ❌ +6.43%

Full diff report 👇
Program Brillig opcodes (+/-) %
nested_array_dynamic 2,370 (+378) +18.98%
nested_array_in_slice 1,381 (+181) +15.08%
brillig_rc_regression_6123 203 (+24) +13.41%
nested_dyn_array_regression_5782 182 (+15) +8.98%
regression_struct_array_conditional 579 (+44) +8.22%
brillig_nested_arrays 182 (+11) +6.43%
fold_2_to_17 651 (+34) +5.51%
bench_2_to_17 373 (+17) +4.78%
poseidon2 380 (+17) +4.68%
hashmap 21,423 (+898) +4.38%
no_predicates_numeric_generic_poseidon 828 (+34) +4.28%
fold_numeric_generic_poseidon 828 (+34) +4.28%
array_sort 316 (+12) +3.95%
array_dynamic_nested_blackbox_input 905 (+33) +3.78%
brillig_cow 392 (+12) +3.16%
uhashmap 13,909 (+381) +2.82%
wildcard_type 297 (+7) +2.41%
eddsa 10,890 (+203) +1.90%
bigint 2,029 (+33) +1.65%
slices 2,068 (+31) +1.52%
regression_5252 4,723 (+69) +1.48%
array_to_slice 830 (+12) +1.47%
to_be_bytes 214 (+3) +1.42%
6 1,145 (+16) +1.42%
conditional_regression_short_circuit 1,218 (+16) +1.33%
poseidon_bn254_hash 5,520 (+72) +1.32%
poseidon_bn254_hash_width_3 5,520 (+72) +1.32%
poseidonsponge_x5_254 4,323 (+54) +1.26%
slice_regex 2,187 (+21) +0.97%
regression_4449 735 (+6) +0.82%
sha256 2,256 (+18) +0.80%
ecdsa_secp256k1 909 (+6) +0.66%
aes128_encrypt 516 (+3) +0.58%
array_dynamic_blackbox_input 1,033 (+6) +0.58%
conditional_1 1,200 (+6) +0.50%
sha256_var_witness_const_regression 1,250 (+6) +0.48%
sha2_byte 2,826 (+12) +0.43%
regression 735 (+3) +0.41%
sha256_var_size_regression 1,723 (+6) +0.35%
slice_dynamic_index 2,646 (+6) +0.23%
sha256_regression 6,580 (+12) +0.18%
sha256_var_padding_regression 4,795 (+2) +0.04%

Copy link
Contributor

Changes to circuit sizes

Generated at commit: a8a76baa85ec4a781e0f12c9d62f3be427628476, compared to commit: 45eb7568d56b2d254453b85f236d554232aa5df9

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_dynamic +161 ❌ +4.91% +283 ❌ +2.24%
array_dynamic_nested_blackbox_input +6 ❌ +2.43% +17 ❌ +0.23%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
nested_array_dynamic 3,442 (+161) +4.91% 12,933 (+283) +2.24%
array_dynamic_nested_blackbox_input 253 (+6) +2.43% 7,326 (+17) +0.23%

@jfecher
Copy link
Contributor Author

jfecher commented Nov 22, 2024

Curious that opcode & constraint count diffs are the same as in #6585, but unlike that PR the opcodes executed is unchanged from master?

Maybe its because the other PR has more commits, and if opcodes executed becomes unchanged then the comment isn't updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants