address comments

Signed-off-by: Shuning Chen <[email protected]>
nolouch · Dec 11, 2023 · 2069df0 · 2069df0
1 parent 28b2136
commit 2069df0
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/client/resource_group/controller/controller.go b/client/resource_group/controller/controller.go
@@ -1218,8 +1218,6 @@ func (gc *groupCostController) onRequestWait(
 				}
 				if d, err = WaitReservations(ctx, now, res); err == nil {
 					break retryLoop
-				} else if d.Seconds() > 0 {
-					gc.failedLimitReserveDuration.Observe(d.Seconds())
 				}
 			case rmpb.GroupMode_RUMode:
 				res := make([]*Reservation, 0, len(requestUnitLimitTypeList))
@@ -1230,8 +1228,6 @@ func (gc *groupCostController) onRequestWait(
 				}
 				if d, err = WaitReservations(ctx, now, res); err == nil {
 					break retryLoop
-				} else if d.Seconds() > 0 {
-					gc.failedLimitReserveDuration.Observe(d.Seconds())
 				}
 			}
 			gc.requestRetryCounter.Inc()
@@ -1240,6 +1236,9 @@ func (gc *groupCostController) onRequestWait(
 		}
 		if err != nil {
 			gc.failedRequestCounter.Inc()
+			if d.Seconds() > 0 {
+				gc.failedLimitReserveDuration.Observe(d.Seconds())
+			}
 			gc.mu.Lock()
 			sub(gc.mu.consumption, delta)
 			gc.mu.Unlock()