pd-ctl: disable EnablePrefixMatching and avoid misuse of `store remov…

…e` and `store delete` (tikv#8414) close tikv#8413 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
nolouch · Jul 22, 2024 · 7b014aa · 7b014aa
1 parent 8de0412
commit 7b014aa
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/tools/pd-ctl/pdctl/command/store_command.go b/tools/pd-ctl/pdctl/command/store_command.go
@@ -706,7 +706,11 @@ func showAllStoresLimitCommandFunc(cmd *cobra.Command, args []string) {
 	cmd.Println(r)
 }
 
-func removeTombStoneCommandFunc(cmd *cobra.Command, _ []string) {
+func removeTombStoneCommandFunc(cmd *cobra.Command, args []string) {
+	if len(args) != 0 {
+		cmd.Usage()
+		return
+	}
 	prefix := path.Join(storesPrefix, "remove-tombstone")
 	_, err := doRequest(cmd, prefix, http.MethodDelete, http.Header{})
 	if err != nil {

diff --git a/tools/pd-ctl/pdctl/ctl.go b/tools/pd-ctl/pdctl/ctl.go
@@ -29,7 +29,7 @@ import (
 )
 
 func init() {
-	cobra.EnablePrefixMatching = true
+	cobra.EnablePrefixMatching = false
 	cobra.EnableTraverseRunHooks = true
 }
 

diff --git a/tools/pd-ctl/tests/store/store_test.go b/tools/pd-ctl/tests/store/store_test.go
@@ -339,9 +339,14 @@ func TestStore(t *testing.T) {
 	// store delete <store_id> command
 	storeInfo.Store.State = metapb.StoreState(metapb.StoreState_value[storeInfo.Store.StateName])
 	re.Equal(metapb.StoreState_Up, storeInfo.Store.State)
+	args = []string{"-u", pdAddr, "store", "remove", "1"} // it means remove-tombstone
+	output, err = tests.ExecuteCommand(cmd, args...)
+	re.NoError(err)
+	re.NotContains(string(output), "Success")
 	args = []string{"-u", pdAddr, "store", "delete", "1"}
-	_, err = tests.ExecuteCommand(cmd, args...)
+	output, err = tests.ExecuteCommand(cmd, args...)
 	re.NoError(err)
+	re.Contains(string(output), "Success")
 	args = []string{"-u", pdAddr, "store", "1"}
 	output, err = tests.ExecuteCommand(cmd, args...)
 	re.NoError(err)