fix uv morph y axis

noname0310 · Mar 18, 2024 · e184286 · e184286
1 parent e59793c
commit e184286
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 - support Babylon.js 6.46.0
 
+- add missing uv morph y axis inversion
+
 ## 0.37.2
 
 - wasm runtime stabilization

diff --git a/docs/static/pmx_converter/main.bundle.js b/docs/static/pmx_converter/main.bundle.js
diff --git a/src/Loader/pmLoader.ts b/src/Loader/pmLoader.ts
@@ -707,7 +707,7 @@ export abstract class PmLoader extends MmdModelLoader<PmLoadState, PmxObject, Pm
 
                             const elementIndex = indexToSubMeshIndexMap[morphIndices[j]];
                             uvs[elementIndex * 2 + 0] += uvOffsets[j * 4 + 0];
-                            uvs[elementIndex * 2 + 1] += uvOffsets[j * 4 + 1];
+                            uvs[elementIndex * 2 + 1] -= uvOffsets[j * 4 + 1]; // flip y axis
                             indexCount += 1;
                         }
 
@@ -719,7 +719,7 @@ export abstract class PmLoader extends MmdModelLoader<PmLoadState, PmxObject, Pm
                             const elementIndex = indexToSubMeshIndexMap[morphIndices[j]];
                             indices[k] = elementIndex;
                             offsets[k * 4 + 0] = uvOffsets[j * 4 + 0];
-                            offsets[k * 4 + 1] = uvOffsets[j * 4 + 1];
+                            offsets[k * 4 + 1] = -uvOffsets[j * 4 + 1]; // flip y axis
                             offsets[k * 4 + 2] = uvOffsets[j * 4 + 2];
                             offsets[k * 4 + 3] = uvOffsets[j * 4 + 3];
                             k += 1;
@@ -735,7 +735,7 @@ export abstract class PmLoader extends MmdModelLoader<PmLoadState, PmxObject, Pm
 
                             const elementIndex = indexToSubMeshIndexMap[morphIndices[j]];
                             uvs[elementIndex * 2 + 0] += uvOffsets[j * 4 + 0];
-                            uvs[elementIndex * 2 + 1] += uvOffsets[j * 4 + 1];
+                            uvs[elementIndex * 2 + 1] -= uvOffsets[j * 4 + 1]; // flip y axis
                         }
                     }
 

diff --git a/src/Test/Scene/shadingTestScene.ts b/src/Test/Scene/shadingTestScene.ts
@@ -32,8 +32,8 @@ export class SceneBuilder implements ISceneBuilder {
         createDefaultGround(scene);
         const mmdMesh = await SceneLoader.ImportMeshAsync(
             undefined,
-            "res/private_test/model/Sour式初音ミクVer.1.02/",
-            "Black.pmx",
+            "res/private_test/model/YYB Delta_M Miku_2.1/",
+            "delta_M2.0.pmx",
             scene
         ).then(result => result.meshes[0]) as Mesh;
         shadowGenerator.addShadowCaster(mmdMesh);