Bot sends a message when a single meeting is edited. #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad2ffba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Mikhail Aheichyk <[email protected]>
maheichyk
force-pushed
the
nic/feat/PB-3534-message-edit-single-occurrence
branch
from
6acb39e to
480b567
Compare
dhenneke
reviewed
Oct 10, 2023
There was a problem hiding this comment.
The general pattern with the union type for different types of changes and the e2e tests are fine 👍.
I think that we could do some larger refactorings of the message-code so it is more resilient and we could get rid of some unnecessarily complex legacy-code that piled up during the migration to the new data format.
matrix-meetings-bot/src/shared/calendarUtils/extractCalendarChange.test.ts
Outdated
Show resolved
Hide resolved
matrix-meetings-bot/src/shared/calendarUtils/extractCalendarChange.ts
Outdated
Show resolved
Hide resolved
matrix-meetings-bot/src/shared/calendarUtils/extractCalendarChange.ts
Outdated
Show resolved
Hide resolved
matrix-meetings-bot/src/shared/calendarUtils/extractCalendarChange.ts
Outdated
Show resolved
Hide resolved
added 7 commits
October 17, 2023 12:23
Signed-off-by: Mikhail Aheichyk <[email protected]>
…he old occurrence start and end Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
dhenneke
reviewed
Oct 17, 2023
added 2 commits
October 18, 2023 09:49
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
dhenneke
reviewed
Oct 18, 2023
Co-authored-by: Dominik Henneke <[email protected]> Signed-off-by: maheichyk <[email protected]>
Signed-off-by: Mikhail Aheichyk <[email protected]>
dhenneke
approved these changes
Oct 19, 2023
|
@dhenneke many thanks for the comments and review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the bot is updated to send a message with meeting details into the room when a single meeting is edited.
✔️ Checklist
Signed-off-byline in the message (more info).