Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike: Infinite Canvas #657

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Spike: Infinite Canvas #657

wants to merge 16 commits into from

Conversation

HarHarLinks
Copy link
Contributor

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4feade9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

HarHarLinks
HarHarLinks commented Dec 3, 2024
View reviewed changes
packages/react-sdk/src/store/canvasSlice.ts Outdated
return state;
}

if (newScale > 5) {
Copy link
Contributor Author

@HarHarLinks HarHarLinks Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 (and 1) should be a const in constants.ts. We also need them as a transformation factor to scale between the canvas coordinate system and the viewport coordinate system.

HarHarLinks
HarHarLinks commented Dec 3, 2024
View reviewed changes
packages/react-sdk/src/components/Whiteboard/constants.ts
Comment on lines +20 to +21
export const whiteboardWidth = 9600;
export const whiteboardHeight = 5400;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use initialWhiteboardWidth * $maxZoom

@weeman1337 weeman1337 force-pushed the nic/spike/infinite-canvas branch from 9d6a741 to 75137c5 Compare December 16, 2024 08:31
weeman1337 and others added 16 commits December 16, 2024 09:32
@weeman1337
Add infinite canvas experiment
9f37e15 
Signed-off-by: Michael Weimann <[email protected]>
@HarHarLinks @weeman1337
rename variables for clarity
031817f 
Signed-off-by: Kim Brose <[email protected]>
@HarHarLinks @weeman1337
fix element bar positionBelow
63e471d 
Signed-off-by: Kim Brose <[email protected]>
@HarHarLinks @weeman1337
fix elementBar position depending on screen size
59ca773 
Signed-off-by: Kim Brose <[email protected]>
@HarHarLinks @weeman1337
fix elementBar position when zooming
dc2c615 
Signed-off-by: Kim Brose <[email protected]>
@weeman1337
WiP
948153c 
Signed-off-by: Michael Weimann <[email protected]>
@weeman1337
WiP
15a6a26 
Signed-off-by: Michael Weimann <[email protected]>
@HarHarLinks @weeman1337
fix constants
a586d27 
Signed-off-by: Kim Brose <[email protected]>
@HarHarLinks @weeman1337
position element bar when zoomed out
6a45fbb 
Signed-off-by: Kim Brose <[email protected]>
@HarHarLinks @weeman1337
position element bar when zoomed out and in
e86ff2c 
Signed-off-by: Kim Brose <[email protected]>
@HarHarLinks @weeman1337
position element bar when translating the canvas
0224906 
Signed-off-by: Kim Brose <[email protected]>
@weeman1337
Disable outer scale
df367fb 
Signed-off-by: Michael Weimann <[email protected]>
@HarHarLinks @weeman1337
collab on matrix
21d0e56 
Signed-off-by: Kim Brose <[email protected]>
@weeman1337
Iterate
75137c5 
Signed-off-by: Michael Weimann <[email protected]>
@weeman1337
Use store scale everywhere
c5ead8d 
Signed-off-by: Michael Weimann <[email protected]>
@weeman1337
Use correct scaling
4feade9 
Signed-off-by: Michael Weimann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HarHarLinks @weeman1337