Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use state in App for the active whiteboard. #676

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

weeman1337
Copy link
Contributor

Before it may have changed the state between renders outside of hooks. That lead to errors, such as Cannot update a component ... while rendering a different component.

✔️ Checklist

  • A changeset describing the change and affected packages (more info).
  • Added or updated documentation.
  • Tests for new functionality and regression tests for bug fixes.
  • Screenshots or videos attached (for UI changes).
  • All your commits have a Signed-off-by line in the message (more info).

@weeman1337 weeman1337 marked this pull request as ready for review December 12, 2024 14:21
@weeman1337 weeman1337 requested a review from a team as a code owner December 12, 2024 14:21
jaller94
jaller94 previously approved these changes Dec 13, 2024
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 4c21d97

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@weeman1337 weeman1337 force-pushed the nic/fix/NEO-1046-cannot-update-component branch from 0f989e8 to d758084 Compare December 13, 2024 14:01
Before it may have changed the state between renders outside of hooks.
That lead to errors, such as Cannot update a component ... while
rendering a different component.

Signed-off-by: Michael Weimann <[email protected]>
@weeman1337 weeman1337 requested a review from jaller94 December 13, 2024 14:01
@weeman1337 weeman1337 force-pushed the nic/fix/NEO-1046-cannot-update-component branch from d758084 to 4c21d97 Compare December 13, 2024 14:01
Copy link
Contributor

@jaller94 jaller94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good to me.
Though the force-pushed base: '', change looks kind of random and I don't see it in the overall diff. Did some merge confuse Github?

https://github.com/nordeck/matrix-neoboard/compare/d758084566c664f30c282c48e5b655fce2c43ba0..4c21d97116e434eca186db6cfb1cb0446722134a

@weeman1337 weeman1337 merged commit cb65ca6 into main Dec 16, 2024
4 checks passed
@weeman1337 weeman1337 deleted the nic/fix/NEO-1046-cannot-update-component branch December 16, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants