Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowlist role to swap endpoint for sanctions compliance #725

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Nov 13, 2023

NO-3363

Put swap behind a role that we can use to allowlist addresses.

Copy link

swarmia bot commented Nov 13, 2023

@amiecorso amiecorso requested a review from rlfarman November 13, 2023 23:03
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (73d2247) 54.7% compared to head (4b9d2cb) 64.1%.

Files Patch % Lines
contracts/Market.sol 66.6% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #725     +/-   ##
========================================
+ Coverage    54.7%   64.1%   +9.4%     
========================================
  Files          14      14             
  Lines         979     980      +1     
  Branches      152     152             
========================================
+ Hits          536     629     +93     
+ Misses        386     292     -94     
- Partials       57      59      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openzeppelin-code bot commented Nov 13, 2023

Add allowlist role to swap endpoint for sanctions compliance

Generated at commit: 4b9d2cb004d8746ed9251e27584204f36f576c7e

🚨 Vulnerabilities Summary

Process Issues Results
Contract Inspector note
low
Total
33
12
45
Dependency Checker Total 0

For more details view the full report in OpenZeppelin Code

contracts/Market.sol Outdated Show resolved Hide resolved
@amiecorso amiecorso requested a review from rlfarman November 14, 2023 17:50
Copy link
Contributor

@rlfarman rlfarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

【LGTM】

@amiecorso amiecorso merged commit 9b8dbd5 into master Nov 14, 2023
7 of 8 checks passed
@amiecorso amiecorso deleted the amie-allowlist-swap branch November 14, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants