Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove floor in Market.setPurchasingTokenAndPriceMultiple #737

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

amiecorso
Copy link
Contributor

@amiecorso amiecorso commented Mar 11, 2024

Copy link

swarmia bot commented Mar 11, 2024

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.8%. Comparing base (599f58e) to head (e0ea3eb).

Files Patch % Lines
contracts/Market.sol 0.0% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #737   +/-   ##
======================================
  Coverage    67.8%   67.8%           
======================================
  Files          12      12           
  Lines         788     788           
  Branches      130     130           
======================================
  Hits          535     535           
  Misses        205     205           
  Partials       48      48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Remove floor in Market.setPurchasingTokenAndPriceMultiple

Generated at commit: e0ea3ebdcb93f77ca3065c9e37b972d9d731525a

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
2
0
8
34
45
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
1
36
37

For more details view the full report in OpenZeppelin Code Inspector

@amiecorso amiecorso requested a review from rlfarman March 11, 2024 20:35
@amiecorso amiecorso merged commit 3b8d1f1 into master Mar 11, 2024
9 of 11 checks passed
@amiecorso amiecorso deleted the amie-remove-price-floor branch March 11, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants