Update how annual totals are recorded in the quantification package #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| mapUnitAreaInM2: number; | ||
| }): number => { | ||
| const gramsOfCarbonForMapUnitInM2 = multiply(gramsPerM2, mapUnitAreaInM2); | ||
| const tonnesOfCarbonForMapUnit = divide( |
There was a problem hiding this comment.
fwiw the unit utility from mathjs is better suited for this purpose. I'm posting this just as a reminder for the future, I don't think that change needs to happen here
jaycenhorton
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow SAMs better insights into how the somsc differences were calculated, we should also record the numbers used to generate the differences (IE - the totals for both the future and baseline scenarios).
More work to be done in terms of how this affects how quantification results are consumed by other Nori services, but this at least gives us the opportunity to run the quantification CLI to get these results (since our SAMs need these numbers now).