Improve editorconfig #92
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 5849642615
💛 - Coveralls |
| trim_trailing_whitespace = true | ||
| insert_final_newline = true | ||
| max_line_length = 2000 |
There was a problem hiding this comment.
This key doesn't seem standard. Do editors respect this? Also the value of 2000 looks a bit random to me.
There was a problem hiding this comment.
I do not use an IDE. (stone age viktor)
eclint in my CI workflow respects it.
SVG files have ~1000 long lines.
There was a problem hiding this comment.
This feature request has 56 👍🏻-s.
editorconfig/editorconfig-vscode#272
| block_comment_start = /* | ||
| block_comment = * | ||
| block_comment_end = */ |
There was a problem hiding this comment.
Hm, these keys aren't present in the spec as well. Any reason to add them?
There was a problem hiding this comment.
These are for eclint to understand block comments.
What should I do?
| indent_style = space | ||
| indent_size = 2 | ||
| [src/**] | ||
| max_line_length = 120 |
There was a problem hiding this comment.
See above. Also prettier, eslint and vscode are all configured to use 100 characters max.
There was a problem hiding this comment.
There are many lines in src/ exceeding 100 characters in length.
Should I modify this line?
Only
src/__tests__/utils/unicode.data.tshas 120+ long lines.Maybe TypeScript has a feature to break long lines.