Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hundreds of clippy warnings #119

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

joseluis
Copy link
Contributor

Single instances of: clippy::wrong_self_convention, clippy::enum_variant_names and clippy::vec_box are allowed, since the solutions albeit potentially simple are nevertheless non-straight forward.

@knickish
Copy link
Collaborator

@not-fl3 will have to weigh in on this one, historically has not liked some of the clippy conventions. Other than the change to the unsafe block (which should be in a separate PR in my opinion), I'm happy to merge it if he approves

@joseluis
Copy link
Contributor Author

joseluis commented Nov 14, 2024

Fantastic. I don't mind changing something for a global preference. I considered it for needless_return but ended up rustifying them.

Both changes inside unsafe blocks are needless_borrow which indeed warns the semantics could change in unsafe blocks, but in this case on one side it passes miri and on the other if I understand it correctly &*expr de-rreferences expr then re-references it immediately, which is a no-op that doesn't seem to serve any extra purpose like coercing lifetimes... But I don't mind separating it if that's gonna be easier.

@knickish
Copy link
Collaborator

I still would prefer the unsafe one to be a separate PR. The change itself looks good though

- aLlow single instances of: `clippy::wrong_self_convention`, `clippy::enum_variant_names` and `clippy::vec_box`.
- rustfmt.
@joseluis joseluis force-pushed the feat-lint branch 2 times, most recently from 9dee8ad to 46d9d1d Compare November 18, 2024 10:21
@joseluis
Copy link
Contributor Author

I've removed the unsafe-related changes and will do a different PR.

@knickish
Copy link
Collaborator

Thanks!

@knickish knickish merged commit d42a6b2 into not-fl3:master Nov 18, 2024
16 checks passed
@joseluis joseluis deleted the feat-lint branch November 18, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants